Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vcpkg to 2025.01.13 #3158

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Update vcpkg to 2025.01.13 #3158

merged 3 commits into from
Jan 21, 2025

Conversation

tdcosta100
Copy link
Collaborator

Update vcpkg to 2025.01.13 commit tag. Hopefully this will reduce the timeouts in Windows CI workflow.

@tdcosta100 tdcosta100 requested a review from louwers January 19, 2025 19:28
louwers
louwers approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it needs to download a bunch of dependencies as part of configuring? Makes sense to increase it then.

@louwers louwers added github_actions Pull requests that update GitHub Actions code windows labels Jan 20, 2025
@tdcosta100
Copy link
Collaborator Author

Ah it needs to download a bunch of dependencies as part of configuring? Makes sense to increase it then.

Download AND build dependencies, if they are not in cache. This is the reason it takes so long sometimes. I'm considering make just one vcpkg pass, so all build commands benefit from not building the dependencies simultaneously.

@louwers louwers merged commit 5b45d70 into maplibre:main Jan 21, 2025
39 checks passed
@tdcosta100 tdcosta100 deleted the update-vcpkg branch January 22, 2025 04:30
@yousifd yousifd mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgalvan cgalvan cgalvan approved these changes

@louwers louwers louwers approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdcosta100 @louwers @cgalvan